search

maleck13 / readline

read line module for node js
92 stars 27 forks source link

afile.txt is needlessly ridiculously large #21

Open apisarenco opened 7 years ago

apisarenco commented 7 years ago

What's the point in afile.txt test fixture? The test is just reading every line of that file and testing if it's not null. With the same success you can have 10 lines of random ASCII characters and not add 1800KB on top of the 1.8KB of code and make it 1000 times bigger. If it's a stress test, then maybe just repeat the test 1000 times.

Plus, as the text reads, "Be sure to check the copyright laws for your country before downloading or redistributing this or any other Project Gutenberg eBook.". Yet this library does not come with a license agreement, and should not need one, and thus should definitely not contain any content that the copyright holder has not renounced all rights to. Therefore this book shouldn't be here even from a legal perspective.

adipascu commented 5 years ago

Relevant blog post https://talbrenev.com/2019/04/16/sherlock-holmes.html

koskimas commented 5 years ago

The file should just be excluded from the distributed package. You can use the files field in package.json to specify the files to distribute.