search

malecki / apsrtable

1 stars 1 forks source link

Dev #2

Closed jknowles closed 9 years ago

jknowles commented 10 years ago

I added a tests file to test merMod objects. I also added some changes to the model.info for merMod objects to include some basic information about the group effects. I think this works pretty well for multiple effects at each level (slope and intercept) and multiple levels of effects. I haven't tested all edge cases, but take a look and see what you think.

I don't know how to improve the stars -- it seems to me like for now the best advice is to set lev=0 and then apsrtable works fine for merMod objects -- it just excludes the stars.

I also added a .gitignore file.

malecki commented 10 years ago

w00t!

On Sun, Sep 7, 2014 at 1:42 PM, Jared Knowles notifications@github.com wrote:

I added a tests file to test merMod objects. I also added some changes to the model.info for merMod objects to include some basic information about the group effects. I think this works pretty well for multiple effects at each level (slope and intercept) and multiple levels of effects. I haven't tested all edge cases, but take a look and see what you think.

I don't know how to improve the stars -- it seems to me like for now the best advice is to set lev=0 and then apsrtable works fine for merMod objects -- it just excludes the stars.

I also added a .gitignore file.

You can merge this Pull Request by running

git pull https://github.com/jknowles/apsrtable dev

Or view, comment on, or merge it at:

https://github.com/malecki/apsrtable/pull/2 Commit Summary

  • add rms functions
  • group effects for merMod

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/malecki/apsrtable/pull/2.

jknowles commented 9 years ago

I've added some additional commits here to fix it so that adding merMod functionality does not break standard lm functionality. I also added functionality for rms objects and fixed an issue with sidewaystable where captions and labels were not being used.

malecki commented 9 years ago

awesome. will merge today (so one could install_github) … does it pass R CMD CHECK?

On Sun, Oct 5, 2014 at 11:54 AM, Jared Knowles notifications@github.com wrote:

I've added some additional commits here to fix it so that adding merMod functionality does not break standard lm functionality. I also added functionality for rms objects and fixed an issue with sidewaystable where captions and labels were not being used.

— Reply to this email directly or view it on GitHub https://github.com/malecki/apsrtable/pull/2#issuecomment-57940526.

malecki commented 9 years ago

@jknowles when I try to run merMod.R I get Error in diff(sval) : error in evaluating the argument 'x' in selecting a method for function 'diff': Error in svd(x, 0, 0) : a dimension is zero

jknowles commented 9 years ago

@malecki svd looks like that is an issue with lme4 and a model not running correctly. I'll look into it. merMod.R is certainly not a good test suite -- more of a sandbox where I was messing around making sure I made the proper changes.

I am not sure how to work out a formal test for this, but I have been thinking about it.

I'll check if it passes R CMD CHECK later this week. I am using this to produce the tables for my dissertation and it just works so nicely. Happy to keep contributions coming.