malenaalmasi / py_practice

0 stars 0 forks source link

Rewrite this codebase #1

Open hjmjohnson opened 6 years ago

hjmjohnson commented 6 years ago

The solution here:

https://github.com/malenaalmasi/py_practice/blob/1352ec63499d4fc0bf0718090f9757c012d3bc3c/array_multiplication.py#L18

is extremely rudimentary programming style that is insufficient for managing the complexities that are involved with medical imaging.

1) There are no comments. 2) There are no functions 3) single letter variable names are taboo in well written software. Variable names must be words or phrases that convey their intended purpose. The only exceptions are 'i' for index where it is blatantly obvious that you are indexing, or 'x', 'y', 'z' for indexes in to 3D numerical data structures.

Please rewrite so that this code is reusable and readable by other freshman level developers.