search

malenaalmasi / py_practice

0 stars 0 forks source link

Improved software engineering needed. #4

Open hjmjohnson opened 6 years ago

hjmjohnson commented 6 years ago

Again,

I don't know what you were attempting to do, so I can not evaluate if you were successful.

https://github.com/malenaalmasi/py_practice/blob/1352ec63499d4fc0bf0718090f9757c012d3bc3c/line.py#L2

You can use the WIKI pages to document what you are attempting to accomplish, then I can review to determine if you reached those goals.

======= This is a good start, but your programming skills are still very very rudimentary. You will need to practice and develop more software engineering skills/discipline so that you will be able to handle the complexity of solving more difficult problems. The skills demonstrated so far are similar to the skills of freshman first time programmer with a few months of practice. I will need you to be able to fluently program at a graduate level in order to address the complex problems of medical imaging.

As an example, a rudimentary problem would involve understanding and modifying the codebase for https://github.com/NifTK/NiftyNet

Please review that source code to better understand the level of complexity that will be expected of a graduate student in medical image processing.

You are doing good so far, but you need to focus on good software engineering practices.

Hans

hjmjohnson commented 6 years ago

@malenaalmasi Please look at the GitHub issues for comments.

malenaalmasi commented 6 years ago

Dear professor Johnson,

I appreciate your detailed comments about my programming. I will make sure to apply all your comments and improve my coding. I will rewrite it in a better way. After looking at the well-written codes, I understood how well I should get in Python. I am going to do my best to get to an appropriate level as soon as possible. I will notify you about my progress as usual. I am so thankful for your support and comments.

Regards

Azam (Malena) E-mail: malena.almasi@gmail.com mobile: (737)- 6150543 address: 402 6th street, Coralville, Iowa city, 52241.

From: Hans Johnson Sent: Tuesday, October 2, 2018 9:54 AM To: malenaalmasi/py_practice Cc: malenaalmasi; Mention Subject: Re: [malenaalmasi/py_practice] Improved software engineering needed.(#4)

@malenaalmasi Please look at the GitHub issues for comments. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.