malept / thermite

A Rake-based helper for building and distributing Rust-based Ruby extensions
http://www.rubydoc.info/github/malept/thermite
MIT License
139 stars 11 forks source link

Why isn't this using .bundle on macOS? #42

Open malept opened 6 years ago

malept commented 6 years ago

@sgrif mentioned this in a "The Bikeshed" episode (starts at 3:18).

Currently, every platform ends in .so (see https://github.com/malept/thermite/commit/57880e6dfcf42bfba11f9642ab3a34e70cc525d2). It used to be that everything had its own platform-specific extension, and there was a special case for .bundle to rename it to .dylib, but I don't remember why (it was at least a year and a half ago, and I foolishly forgot to document why).

In theory, it should be fine just changing the extension.

sgrif commented 6 years ago

In case Twitter goes away or is inaccessible for some folks, I had mentioned on there that:

In my (extremely limited) experience, literally renaming .dylib to .bundle fixed it which was very surprising.