search

malept / thermite

A Rake-based helper for building and distributing Rust-based Ruby extensions
http://www.rubydoc.info/github/malept/thermite
MIT License
139 stars 11 forks source link

Relax semantic versioning strictness #45

Closed danielpclark closed 6 years ago

danielpclark commented 6 years ago

Allows for matching: 0.3.2 v0.3.2 v0.3.0-rc1 v0.3.2.beta13 0.5.3.alpha1 0.5.3.1

malept commented 6 years ago

v0.3.2.beta13 0.5.3.alpha1 0.5.3.1

These aren't valid per the semver 2.0.0 spec. I think I would rather conform strictly to semver by default than have it be a hybrid scheme. Besides, this is configurable via the Thermite options (git_tag_regex).

malept commented 6 years ago

@danielpclark I've made an alternate proposal in PR #46. Let me know if that change as a default plus the ability to customize the version regex (which is already implemented) works for your use case.