search

malihu / page-scroll-to-id

Animated page scrolling to specific id within the document with jquery.
MIT License
224 stars 98 forks source link

Minifying 1.5.8. not working for WP 1.6.2 #16

Closed PPAAUULL closed 6 years ago

PPAAUULL commented 6 years ago

The jquery.malihu.PageScroll2id.js differs from the current minified version included in wordpress (1.5.6 vs 1.6.2). Would be really nice if you could update the unminified js!

malihu commented 6 years ago

Yes this is correct.

The WordPress plugin 1.6.2 includes page-scroll-to-id 1.5.6.

The latest page-scroll-to-id version (1.5.8) is already included in the WordPress plugin development version which will be released as version 1.6.3.

If you want to use page-scroll-to-id 1.5.8 in WordPress before version 1.6.3 is released, you can download and use the development version.

PPAAUULL commented 6 years ago

Thank You – unfortunately it does not solve my issue. I wanted to modify the jquery.malihu.PageScroll2id.js and use it instead of the minified js. But that's not working.

  1. Does the minified js contain more than the jquery.malihu.PageScroll2id.js?
  2. How do you minify?
malihu commented 6 years ago

Yes, the minified version of the WordPress plugin (page-scroll-to-id.min.js) contains the following: jquery.malihu.PageScroll2id.js jquery.malihu.PageScroll2id-init.js

Both of these unminified files are contained in plugin's js directory.

In WordPress, you can instruct the plugin to load the non-minified/development version of its scripts (i.e. the 2 files above) instead of the minified/production-ready one, by adding:

define('PS2ID_MINIFIED_JS', false);

to your wp-config.php

PPAAUULL commented 6 years ago

Thank You!