search

maliit / framework

Core libraries of Maliit and server.
Other
52 stars 49 forks source link

WIP: Maliit 3 major refactoring #108

Open dobey opened 2 years ago

dobey commented 2 years ago

I've made this draft PR and requested reviews from @mikhas @jpetersen and @pvuorela to get some feedback and make sure the way I'm going with this is the right way forward for getting rid of complex, old, and unused API, while some new API will be added in to allow keyboard plugins to implement better handling across a broader range of devices (such as using a gamepad controller to input text on a large TV), and allow for more interesting user experiences in more traditional scenarios.

pvuorela commented 2 years ago

For very quick glance it's looking nice. Only detail I'm immediately pondering is whether the setLanguage part should be kept. What that code does is allowing empty text field cursor to follow expected text direction. That is for example: device locale in arabic, user has empty text field focused, changes keyboard layout to english. Now by locale the cursor would go to the right hand side of the field and then the first input character would have it jump to the left. With the text direction known the cursor can switch position right after the keyboard layout change.

For above the text direction from input method side would suffice, but then again the input locale is also exposed in QInputMethod API.

dobey commented 2 years ago

Now by locale the cursor would go to the right hand side of the field and then the first input character would have it jump to the left.

But, we cannot change the input direction from the keyboard side, so if I change between RTL and LTR languages in maliit, and sometimes people need to mix languages in the middle of sentences, too. So I think it will be problematic regardless. Though if there is something we need to do more proactively here, perhaps we can do it in a better way now, too. Hopefully such things will be more apparent when this branch gets nearer to being ready to merge.

But for now, I'm also trying to remove things piecemeal so that if something is off in the direction things are headed here, it should be easier to recover smaller things like this if necessary.

pvuorela commented 2 years ago

This is only fallback when the text direction cannot be inferred from the text content. Mostly deciding cursor position on an empty text field.

For reference https://github.com/qt/qtdeclarative/blob/dev/src/quick/items/qquicktextedit.cpp#L808