search

maliit / framework

Core libraries of Maliit and server.
Other
52 stars 49 forks source link

Install unit test files again #96

Closed pvuorela closed 2 years ago

pvuorela commented 2 years ago

Before switch to cmake on commit 7471153ce the unit test files were installed, and with cmake there are some parts of it done. Reintroduce the installation as these are needed if the build environment is not, and perhap cannot be, used for testing.

Also cope on the qml unit test for the example plugin not available as it's built optionally.

pvuorela commented 2 years ago

Made the test installation optional.

On the qml example file installation it would feel a strange rule to install it if examples are built OR if tests are built and installed. Then again the whole double role of the qml file is suspicious. Would be cleaner if there was a qml file as an example and another for testing. Since nobody else has seemed to miss installable tests for a while and the test is small, I can live with just skipping it for now if the file is not available.

dobey commented 2 years ago

On the qml example file installation it would feel a strange rule to install it if examples are built OR if tests are built and installed. Then again the whole double role of the qml file is suspicious. Would be cleaner if there was a qml file as an example and another for testing. Since nobody else has seemed to miss installable tests for a while and the test is small, I can live with just skipping it for now if the file is not available.

Well, it's just a QML file, so there's nothing to "build" for examples. So let's just move it into the tests tree instead? Maybe all the examples should just be part of tests instead of being examples, and anything which is problematic we should just get rid of at this point?

pvuorela commented 2 years ago

Alright. Added couple of comments for adjusting the qml test/example file setup. Removing some obsolete files that haven't been used since 2013, making the remaining file as test asset since it's more suitable for that, and some unit test cleanups. The test passes now both in-tree and installed.

pvuorela commented 2 years ago

@dobey anything else here?