search

malijs / mali

A minimalistic gRPC microservice framework for Node.js
https://mali.js.org
Apache License 2.0
888 stars 60 forks source link

Stabilize test #378

Closed n0v1 closed 4 months ago

n0v1 commented 4 months ago

After #377 was merged I noticed that tests sometimes still fail with No address added out of total 1 resolved. I opted to use get-port module to get real unused ports instead of using just some random number between 1000 and 65000.

With those changes test runs seem stable.

anonrig commented 4 months ago

Can you also remove coveralls from GitHub actions?

n0v1 commented 4 months ago

Do you mean removing all stuff related to coveralls from .github/workflows/nodejs.yml? I noticed that sending coverage report failed every now and then with Can't add a job to a build that is already closed.. This should be fixed now by properly waiting until all parallel runs finished (208733e02db0e62d29ecf2babd68a557a5e20f12). Should I still remove coveralls?

anonrig commented 4 months ago

let's keep it as it is

n0v1 commented 4 months ago

Thanks for merging! Now that tests are stable, is there any chance to release a new version soon? In particular to make mali compatible with @grpc/grpc-js v1.10.x (fixed by #375).

anonrig commented 4 months ago

Yes I'll release a version today. Although, I'm not sure if I still have the permission. cc @bojand

bojand commented 4 months ago

Hello, yes you should still have write access to the NPM package. Please proceed.

andres06-hub commented 4 months ago

Hi, I think you have not created the version yet, could you help with this please.

ScripterSugar commented 4 months ago

reminder ping @anonrig 🙏

n0v1 commented 2 months ago

@anonrig, @bojand, is there anything blocking a new release including this fix?