malikhollins / HungerGamesSimulator

A hunger games simulator built using the .net blazor framework
0 stars 1 forks source link

Designer Strings V2 #45

Closed malikhollins closed 6 months ago

malikhollins commented 9 months ago

There is a lot to improve on with designer strings, but I don't have the time.

Adding Type of text to JSON Users should be able to specify the type of text, e.g. append, prepend, etc. so that they can generate a richer paragraph.

Differentiating between inputs better

  {
    "Contexts": [ "Combat", "Flavor" ],
    "Inputs": [
      {
        "Type": "Tribute"
      },
      {
        "Type": "Tribute"
      }
    ],
    "Texts": [
      "{input[0]} attacks {input[1]} after noticing they were alone"
    ]
  }

A JSON object like this does not specify which tribute has to attack which, so who initiated this action is lost in the designer string. A solution can be creating a wrapper for tribute that has a property Initiated Attack, but I'd to know other possible solutions to this issue.

malikhollins commented 6 months ago

Append Fake Attributes to each input?

E.G. buildDesignerString( ...inputs, ...inputsAttributes ) ?? Create list of boolean attributes??

malikhollins commented 6 months ago

I added context as an input parameter. We really should type protect the input to something other than object...

malikhollins commented 6 months ago

Finished, but not committed to main yet as I need to fix tests.