malikra / TTS-RM

0 stars 0 forks source link

Design/Code Review 1 #4

Closed jereladams closed 6 years ago

jereladams commented 6 years ago

Design/Code Review 1

Project: Task Tracker

Developer: Rashid

Reviewer: Jerel

Item Considerations Comments/Suggestions
Reviewer comments and suggestions go here. Each item should have at least one "kudos" and two suggestions for improvement
Problem Statement 1. Accurately describes project purpose
2. Is professional and free of typos, slang, etc.
3. Fully explains the problem and the solution
4. Is understandable by the average person
Good job explaining problem and solution.
Design Documentation 1. Navigation/flow through the application is logical and easy to use.
2. The order in which values are displayed are logical and easy to understand/use
3. The order in which the form fields entered are logical and easy to understand/use
4. All data discussed/documented (problem statement, flow, db design, etc.) is represented on the screens
Very nice job detailing the Application Flow. Continue researching API that interacts with the calendar. Finish adding links to your Database Design docs in the readMe.
Data model/Database 1. Everything on the screens and problem statement/flow is represented in the model
2. There is at least one 1-to-many relationship.
3. The model represents good database design
Finalize tables and database design.
Code 1. Proper Maven project structure is used
2. a .gitignore file for IntelliJ Java projects has been implemented
3. There is not any redundant or copy/paste code in the JSPs or classes
4. Classes are appropriately-sized (no monster classes)
Property files are used appropriately: no hard-coded values
5. Logging statements are used rather than System.out.println and printStackTrace.
6. There are appropriate unit tests/code coverages.
N/A
pawaitemadisoncollege commented 6 years ago

@jereladams Did you check for system.out.println statements?

malikra commented 6 years ago

Done !