issues
search
malikra
/
TTS-RM
0
stars
0
forks
source link
Final Code Review
#5
Open
sgtmms
opened
6 years ago
sgtmms
commented
6 years ago
Design/Code Review 3
Project:Task Calender
Developer: Rashid
Reviewer: Leroy Mims
Category
Criteria
Rating/Comments
Project Overview
Which planned functionality has been met?
It does everything that it should in admin mode
What planned functionality has not been met?
Needs a background to be beautiful. Some @author tags need editing.
Describe the GitHub history and what it demonstrates about the project progress during the semester.
He was done early.
Describe how peer and instructor feedback/recommendations were incorporated into the project.
Cascade on user entity has been implemented
Other comments/notes?
JSPs
Evaluate the JSPs for templating, business logic, data validation, overall look and feel.
There needs to be a background
Other comments/notes?
JSPs need background
Java code quality
Evaluate the code quality for the following and identify specific areas for improvement (class, method or line number)
single-purpose methods
well-structured project
descriptive naming of packages, classes, methods, variables
classes appropriately-sized (no monster classes)
CPD (copy paste detection, meaning are the same lines of code repeated?)
are there candidates for super/subclass relationships, abstract classes, interfaces?
are any values hard-coded that should be in a properties file?
proper exception handling
proper error reporting to the user
code documentation
Everything is concise and documented without redundancy
Other comments/notes?
Logging
Evaluate the use of logging, for example:
appropriate use of logging statements in the code for error logging and debugging
logging levels used - info, debug, error
no occurrences of System.out.printlns or printStackTrace()
logging works on AWS deploy
Logging done on hibernate and Generic DAO.
Other comments/notes?
Unit Tests
Evaluate the unit tests, for example:
tests are truly a unit test rather than a high level functional test
test data is appropriately cleaned up or handled
there is full coverage of methods that perform business logic or utility functions
redundant code is eliminated by using set up and tear down methods, i.e., @Before, @After
Unit tests of Generic DAO with entities are fully implemented with setup and tear down
Other comments/notes?
Security
Evaluate authentication/authorization:
Realm has been implemented
Is it implemented correctly and working locally as well as on AWS?
Other comments/notes?
I don't see a logout servlet.
Web Service/API integration
Evaluate the service/api integration, for example:
Which service/api is implemented?
How is error handling of the service implemented? For example, what happens if the service is not available?
He used Google Calender API and JSON to populate appointments in the calender
Other comments/notes?
Independent research topic
What is the independent research topic?
NA
Is the independent research topic/technique implemented in the project?
NA
Other comments/notes?
Deployment
Has the application been successfully deployed to AWS?
Yes
Is the hosted application fully functioning?
Yes
Other comments/notes?
malikra
commented
6 years ago
Working on it.
Design/Code Review 3
Project:Task Calender
Developer: Rashid
Reviewer: Leroy Mims