search

maliput / delphyne

Scenario and search based Ego/Ado Car traffic simulations
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Removes custom gtest package and uses ament_cmake_gtest instead #717

Closed agalbachicar closed 3 years ago

agalbachicar commented 3 years ago

Solves #714

agalbachicar commented 3 years ago

It's ready for your review @scpeters

scpeters commented 3 years ago

CI failing until #721 is merged

agalbachicar commented 3 years ago

@scpeters whenever you have a moment, please take a look at the output of the jobs. You will find the following log:

> Invoking "sudo locale-gen en_US en_US.UTF-8"
Error: Unable to process command '::set-env name=LANG::en_US.UTF-8' successfully.
Error: The `set-env` command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable to `true`. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

and then it continues but with a failure when running:

> Invoking "sudo rosdep init"
  /usr/bin/sudo rosdep init
  Wrote /etc/ros/rosdep/sources.list.d/20-default.list
  Recommended: please run

    rosdep update

In https://github.com/ToyotaResearchInstitute/delphyne/runs/1408073772?check_suite_focus=true it can be seen that adding the suggested variable above made the step successful.

agalbachicar commented 3 years ago

This is affecting all the jobs, so I will add the fix everywhere to restore CI, then we should probably reach out to https://github.com/ros-tooling/setup-ros so they are aware of it.