search

maliput / delphyne

Scenario and search based Ego/Ado Car traffic simulations
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Simplify /get_scene service #746

Closed scpeters closed 3 years ago

scpeters commented 3 years ago

Currently to get scene information, a delphyne user must advertise a service that expects a Scene message, then call /get_scene with the name of that service. This process is simplified to use only one service call by returning the Scene message directly from /get_scene.

The ProcessSceneRequest method is now unused, so it is removed.

These changes have broken the simulation_runner_test, which expects the old behavior of the /get_scene service. This test will need to be updated before merging.

scpeters commented 3 years ago

I updated the failing test to use the /world_control service instead of /get_scene in 33b7ba0

scpeters commented 3 years ago

my update to the test is a bit flaky on github actions machines :cry:

scpeters commented 3 years ago

rebased and attempting to fix the modified test in 4d8147f. it passes locally for me, so it's a little blind, trying to guess what is going wrong on github actions

scpeters commented 3 years ago

all the actions just failed. I've updated the setup-ros tag to use to the latest one (0.1.2) in eae6578

scpeters commented 3 years ago

I had to rerun the gcc actions one time due to other flaky tests, but I think the test I've updated is now working, so this should be good to go as long as scan_build passes