Don't add Material info for meshes

maliput / delphyne

Scenario and search based Ego/Ado Car traffic simulations

BSD 3-Clause "New" or "Revised" License

0 stars 0 forks source link

Don't add Material info for meshes #764

Closed scpeters closed 3 years ago

scpeters commented 3 years ago

The Scene3D plugin prefers to use the Material info in the Model message over the material info inside a mesh, so it is ignoring the textures specified in the mesh files. This skips adding Material info for Visuals that have meshes so that their built-in Material info can be used.

https://github.com/ignitionrobotics/ign-gui/blob/ignition-gui2_2.3.3/src/plugins/scene3d/Scene3D.cc#L592-L618

This fixes the Prius meshes, but the road markings aren't showing up yet.

Screenshot from 2021-03-11 11-20-19

scpeters commented 3 years ago

this broke a test; I'll fix it

scpeters commented 3 years ago

this broke a test; I'll fix it

LGTM

Would you please check CI?

test should be fixed by 7972387

scpeters commented 3 years ago

latest CI failure was due to merge of https://github.com/ToyotaResearchInstitute/maliput/pull/401; should be fixed by a merge with master

scpeters commented 3 years ago

looks like a flaky failure of UNIT_simulation_runner_test