maliput / delphyne

Scenario and search based Ego/Ado Car traffic simulations
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Supports RuleRegistry and IntersectionBook files in road builder. #822

Closed francocipollone closed 2 years ago

francocipollone commented 2 years ago

Adds arguments to pass both RuleRegistry and IntersectionBook files to the maliput_malidrive-based RoadNetwork loader.

francocipollone commented 2 years ago

Isn't there any test affected? Should we create one?

There are no tests for this, I could create one.

On the other hand, I don't remember a change in the maliput_malidrive plugin, are we missing it?

No change is needed at a plugin level. We are passing just a dictionary with the parameters we want to pass to the maliput_malidrive::builder::RoadNetworkBuilder under the hood. The magic of dictionaries.

francocipollone commented 2 years ago

@agalbachicar Allow me to move forward with this PR and merge it and then tackle the tests in a follow up PR (via issue)