Floating point comparison in if-clause generates warning

maliput / delphyne_gui

Graphical frontend and tools for Delphyne

BSD 3-Clause "New" or "Revised" License

0 stars 0 forks source link

Floating point comparison in if-clause generates warning #429

Open agalbachicar opened 3 years ago

agalbachicar commented 3 years ago

Compilation warning:

/home/agalbachicar/maliput_ws/src/ign-gui0/src/plugins/TimePanel.cc: In member function ‘void ignition::gui::plugins::TimePanel::ProcessMsg()’:
/home/agalbachicar/maliput_ws/src/ign-gui0/src/plugins/TimePanel.cc:278:48: warning: comparing floating point with == or != is unsafe [-Wfloat-equal]
   if (this->dataPtr->msg.real_time_factor() != 0.0)

scpeters commented 3 years ago

this should be moot once we remove our dependency on ignition-gui0 as part of #423, right?