search

maliput / maliput-rs

Rust bindings for maliput and other tools
https://maliput.github.io/maliput-rs/
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Relies on BCR for maliput_malidrive binaries. #10

Closed francocipollone closed 7 months ago

francocipollone commented 8 months ago

🎉 New feature

Closes #8

Requisites

Summary

Test it

cargo run --example create_rn

Checklist

francocipollone commented 8 months ago

:exclamation: CI will fail until https://github.com/bazelbuild/bazel-central-registry/pull/1423 is merged

agalbachicar commented 8 months ago

@francocipollone can you please take a look at https://github.com/bazelbuild/bazel-central-registry/pull/1423, two presubmit checks failed. I think we are missing a few formalities there.

agalbachicar commented 8 months ago

Changes here LGTM btw.

francocipollone commented 8 months ago

@francocipollone can you please take a look at bazelbuild/bazel-central-registry#1423, two presubmit checks failed. I think we are missing a few formalities there.

image https://buildkite.com/bazel/bcr-presubmit/builds/3456#018d6ba5-7ba7-46ea-a71e-b8e89d46e6ff

This is the log and I was expecting a BCR maintainer to inform us if anything is missing. Pinging @stonier as BCR savvy here :smiley: . Do you have extra info in case we are missing something here?

stonier commented 8 months ago

Pinging @stonier as BCR savvy here 😃 . Do you have extra info in case we are missing something here?

I guess the text in that log is pertinent, thanks for finding that.

  1. It explains why it's waiting on a BCR maintainer to process the PR
  2. We should work out how to put the bazel version into that yaml (must be new)

This is the thing we need to update: https://github.com/maliput/maliput_malidrive/blob/main/.bcr/presubmit.yml

Let's see if the BCR Github App makes a new release if we patch that. Or we could just tag a new patch release.

francocipollone commented 7 months ago