search

maliput / maliput-rs

Rust bindings for maliput and other tools
https://maliput.github.io/maliput-rs/
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Enable clippy, fmt and doc in CI #20

Closed francocipollone closed 7 months ago

francocipollone commented 8 months ago

🎉 New feature

Related to #16 Closes https://github.com/maliput/maliput-rs/issues/21

Summary

What the title says

Pendings

Checklist

agalbachicar commented 8 months ago

@francocipollone for my own understanding: does cargo build already take care of formatting the code and making sure all the other checks will pass? If not, can we set at least write in the readme what should be run to make things compliant with the checks we will expect in CI to pass? A precommit / script would be great too.

francocipollone commented 8 months ago

@francocipollone for my own understanding: does cargo build already take care of formatting the code and making sure all the other checks will pass? If not, can we set at least write in the readme what should be run to make things compliant with the checks we will expect in CI to pass? A precommit / script would be great too.

Yeah, I was thinking about having a precommit for this. We can add this to this PR so it is all added together.

francocipollone commented 8 months ago

For some reason the cargo clippy execution is failing in CI. It complains about the build.rs's execution of the bazel module:

ERROR: Skipping '//...': error loading package under directory '': error loading package 'bazel-maliput-sdk/external/yaml-cpp~0.8.0/test/gtest-1.11.0/googletest/test': Unable to find package for @[unknown repo 'rules_python' requested from @]//python:defs.bzl: The repository '@[unknown repo 'rules_python' requested from @]' could not be resolved: No repository visible as '@rules_python' from main repository.

It works correctly locally.

francocipollone commented 7 months ago

I was able to replicate it locally:

docker pull ghcr.io/maliput/maliput-rs-rust-ci:rust1.75.0
docker run -it ghcr.io/maliput/maliput-rs-rust-ci:rust1.75.0 bash
git clone https://github.com/maliput/maliput-rs.git
cd maliput-rs
pre-commit run --all-files --verbose --show-diff-on-failure
francocipollone commented 7 months ago

Bug fixed at https://github.com/maliput/maliput-rs/pull/26

francocipollone commented 7 months ago

Alrighty, bugs are solved. Ready for another pass @agalbachicar :D

francocipollone commented 7 months ago

friendly ping @agalbachicar :smile: