Migrate to newer github action components to avoid deprecation warnings

maliput / maliput_infrastructure

Driving simulation repository for workspace .repo indexes, Makefiles, etc.

BSD 3-Clause "New" or "Revised" License

0 stars 2 forks source link

Migrate to newer github action components to avoid deprecation warnings #319

Closed agalbachicar closed 5 months ago

agalbachicar commented 6 months ago

Desired behavior

Most of the actions/checkout, actions/upload-artifact and alike components are pinned to the latest v3 version. We need to move to v4 to avoid deprecation warnings related to Node.js.

Alternatives considered

N/A

Implementation suggestion

N/A

Additional context

See https://github.com/maliput/maliput_py/actions/runs/7782058733 for example.

https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Due date: 2024/06/30

agalbachicar commented 6 months ago

[x] maliput https://github.com/maliput/maliput/pull/633
[x] maliput_dragway https://github.com/maliput/maliput_dragway/pull/85
[x] maliput_multilane https://github.com/maliput/maliput_multilane/pull/109
[x] maliput_malidrive https://github.com/maliput/maliput_malidrive/pull/281
[x] maliput_sparse https://github.com/maliput/maliput_sparse/pull/59
[x] maliput_py https://github.com/maliput/maliput_py/pull/86
[x] maliput_integration https://github.com/maliput/maliput_integration/pull/138
[x] maliput_integration_test https://github.com/maliput/maliput_integration_tests/pull/82
[x] maliput_object https://github.com/maliput/maliput_object/pull/49
[x] maliput_object_py https://github.com/maliput/maliput_object_py/pull/12
[x] maliput_osm https://github.com/maliput/maliput_osm/pull/56
[x] maliput_sim https://github.com/maliput/maliput_sim/pull/45
[x] maliput_viz https://github.com/maliput/maliput_viz/pull/26
[x] maliput_xodr -- no CI
[x] delphyne https://github.com/maliput/delphyne/pull/863
[x] delphyne_demos https://github.com/maliput/delphyne_demos/pull/62
[x] delphyne_gui https://github.com/maliput/delphyne_gui/pull/499
[x] lanelets_eval https://github.com/maliput/lanelets_eval/pull/51
[x] maliput-rs https://github.com/maliput/maliput-rs/pull/83
[x] .github https://github.com/maliput/.github/pull/8
[x] maliput_documentation https://github.com/maliput/maliput_documentation/pull/159
[x] maliput_infrastructure https://github.com/maliput/maliput_infrastructure/pull/320

agalbachicar commented 6 months ago

Making use of the occasion to update other actions as well:

actions/checkout@v4
actions/upload-artifact@v4
ros-tooling/setup-ros@v0.7 --> it didn't work, I need to keep it in v0.6
codecov/codecov-action@v4
docker/login-action@v3
docker/metadata-action@v5
docker/build-push-action@v5
softprops/action-gh-release@v2
ros-tooling/action-ros-ci@v0.3
actions/setup-python@v5
actions/deploy-pages@v4
actions/upload-pages-artifact@v3
actions/add-to-project@v1

agalbachicar commented 6 months ago

Curiously, all workflows using the manylinux image failed. That is related to a glibc library version installed in the image which collides with a node dependency required by actions/checkout@v4. Seems like sticking to v3 for now is the only way moving forward.

In particular, the manylinux image has glibc-2.17-326.el7_9.x86_64 and the requirement is for glibc 2.25+.

francocipollone commented 5 months ago

Curiously, all workflows using the manylinux image failed. That is related to a glibc library version installed in the image which collides with a node dependency required by actions/checkout@v4. Seems like sticking to v3 for now is the only way moving forward.

In particular, the manylinux image has glibc-2.17-326.el7_9.x86_64 and the requirement is for glibc 2.25+.

Until November 30, 2024 we are ok: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/