This PR enables setting a range of linear tolerances to be used.
A new parameter is accepted to be used when calling the load(std::map<std::string, std::string> params) method: "max_linear_tolerance"
When max_linear_tolerance is passed, the builder will create a range of valid linear tolerances: [linear_tolerance, max_linear_tolerance]. Afterwards, the builder will try building the RoadGeometry scaling from the minimum value of linear tolerance to the maximum, doing increments of 10% of the previous linear tolerance.
The ToleranceSelectionPolicy was deprecated, as this is implicitly enabled when the optional parameter max_linear_tolerance is passed.
The old logic of automatic tolerance selection also increased the angular_tolerance in each iteration. In this PR that behavior is changed the angular_tolerance remains the same. Given that in general, the angular_tolerance isn't an issue when loading maps. If we still want to increase the angular_tolerance in each iteration I think that accepting a max_angular_tolerance parameter would be the way to go.
Part of https://github.com/ToyotaResearchInstitute/maliput_malidrive/issues/130
Summary
This PR enables setting a range of linear tolerances to be used.
load(std::map<std::string, std::string> params)
method: "max_linear_tolerance"max_linear_tolerance
is passed, the builder will create a range of valid linear tolerances:[linear_tolerance, max_linear_tolerance]
. Afterwards, the builder will try building the RoadGeometry scaling from the minimum value of linear tolerance to the maximum, doing increments of 10% of the previous linear tolerance.max_linear_tolerance
is passed.angular_tolerance
in each iteration. In this PR that behavior is changed theangular_tolerance
remains the same. Given that in general, theangular_tolerance
isn't an issue when loading maps. If we still want to increase theangular_tolerance
in each iteration I think that accepting amax_angular_tolerance
parameter would be the way to go.Comments for the reviewers
Reviewing the PR commit by commit is recommended.