Pushes Xodr S continuity check to builder - Githubissues

maliput / maliput_malidrive

Open-source ready OpenDrive backend for Maliput

BSD 3-Clause "New" or "Revised" License

1 stars 2 forks source link

Pushes Xodr S continuity check to builder #185

Open francocipollone opened 3 years ago

francocipollone commented 3 years ago

Addresses https://github.com/ToyotaResearchInstitute/maliput_malidrive/issues/183

Summary

The verification of the xodr s continuity was located at a parser level. Consecuences:

When the tolerance selection mechanism is enabled, for each iteration the builder is re-parsing all the XML again.
RoadGeometryBuilder class is dependency-injected with a DBManager instance, however, in order to be able to include this verification the builder is overriding the DBManager in each iteration which goes against the pattern. See.

This PR moves the verification from the parser to the builder.

Comments for the reviewers

Reviewing the PR commit by commit is recommended.

francocipollone commented 3 years ago

I will downgrade the PR to draft as I need to take a deeper look in order to avoid re-parsing the xodr in each iteration and the solution doesn't seem to be trivial.