maliput / maliput_malidrive

Open-source ready OpenDrive backend for Maliput
BSD 3-Clause "New" or "Revised" License
1 stars 2 forks source link

Supports loading rules via RuleRegistry + new RoadRulebook format. #198

Closed francocipollone closed 2 years ago

francocipollone commented 2 years ago

Part of #193

Summary

Pendings

francocipollone commented 2 years ago

Based on our F2F I split the RoadRulebookBuilder into two different functors:

@agalbachicar Regarding RoadRulebookBuilderOldRules I have my doubts about continuing to populate the new rules in this case. I think that now that we fully support both apis there is no need to have "partially" loaded the new rules when we only care about old rules. It would be simpler if we just : 1 - Care only about old rules when no rule registry is passed and the old format rule is being used. 2 - Care only about new rules when rule registry is passed and the new format rule is being used.

I will continue working now on the test for the RoadRulebook builders.