search

maliput / maliput_malidrive

Open-source ready OpenDrive backend for Maliput
BSD 3-Clause "New" or "Revised" License
1 stars 2 forks source link

Adds LoopRoadPedestrianCrosswalk xodr. #207

Closed francocipollone closed 2 years ago

francocipollone commented 2 years ago

Related to https://github.com/ToyotaResearchInstitute/delphyne_demos/issues/38 Related to https://github.com/ToyotaResearchInstitute/delphyne/pull/835 Related to https://github.com/ToyotaResearchInstitute/delphyne_demos/pull/41

This map is similar to SingleRoadPedestrianCrosswalk(here added) with some changes:

CircleRoadPedestrianCrosswalk

liangfok commented 2 years ago

Actually, can we squash the two commits into one?

liangfok commented 2 years ago

Also, the name "CircleRoad" might be confusing since it's not circle-shaped. Maybe "LoopRoad"?

francocipollone commented 2 years ago

Of course, I will do it. Just for the record: we use Squash and Merge policy when merging so GH will be in charge of squashing everything into one commit.

francocipollone commented 2 years ago

Also, the name "CircleRoad" might be confusing since it's not circle-shaped. Maybe "LoopRoad"?

True!. --> moving to LoopRoadPedestrianCrosswalk.png