search

maliput / maliput_malidrive

Open-source ready OpenDrive backend for Maliput
BSD 3-Clause "New" or "Revised" License
1 stars 2 forks source link

Uses ros-action-ci in build.yaml workflow. #218

Closed francocipollone closed 2 years ago

francocipollone commented 2 years ago

Part of https://github.com/maliput/maliput_infrastructure/issues/274 Related to https://github.com/maliput/maliput_infrastructure/issues/268

Signed-off-by: Franco Cipollone franco.c@ekumenlabs.com

francocipollone commented 2 years ago

CI is failing when running some tests because before running the tests we were requiring to source the install folder, in order to let envars like MALIPUT_MALIDRIVE_RESOURCE_ROOT (which points to install/maliput_malidrive/share/resources) to be valid(via environment hooks).

Some test looks for the resources via this environment variable. An example of this can be found at https://github.com/maliput/maliput_malidrive/blob/7136af97ae5415077c49ad955098610abd3a7f04/test/regression/base/road_geometry_test.cc#L81

I assume this is something that will also be a blocker when pushing maliput_malidrive into the ros build farm. Given that it seems that this needs a refactor, what would be the best approach to follow having in mind other ROS2 packages that may find the same issue?. @agalbachicar @tfoote .

It comes to my mind to add a compile definition pointing to the install/src folder but maybe there is a more ros2-way of doing this.

francocipollone commented 2 years ago

I merged https://github.com/maliput/maliput_malidrive/pull/219 into this branch. Retriggering CI

francocipollone commented 2 years ago

Going in as it was approved at https://github.com/maliput/maliput_malidrive/pull/219