Closed francocipollone closed 2 years ago
LGTM. This won't pass CI until maliput/maliput_drake#23 or maliput/maliput#508 (review) are merged, released, and rebuilt.
maliput
and maliput_drake
have been built already, It should be ok now to be re-triggered.
I tried to retrigger it but I am not sure if I am a bit rusty with jenkins or if I don't have the bits to retrigger it. :D @tfoote
You can request a retry from Jenkins by commenting here like this.
@ros-pull-request-builder retest this please
The build passed, but has linter errors which are why it shows error now.
The build passed, but has linter errors which are why it shows error now.
maliput
(related to old rules api) and therefore when using those and compiling maliput_malidrive
, some warnings are raised.Is it a requirement to fix all the warnings? What's the best approach when using marked-as-deprecated api?
CC: @agalbachicar
Issues were solved via 221 and 222. Build farm should be happy now.
When merging we should: Rebase and Merge
@tfoote Issues are resolved! https://build.ros2.org/job/Fpr__maliput_malidrive__ubuntu_focal_amd64/8/
Part of https://github.com/maliput/maliput_infrastructure/issues/275
action-ros-ci-override: https://gist.githubusercontent.com/francocipollone/18dfba70fefe81314bc8a68138732f53/raw/f87e9a6f8e2a6241fbe79db063158bfca5972b41/prs.repos