maliput / maliput_malidrive

Open-source ready OpenDrive backend for Maliput
BSD 3-Clause "New" or "Revised" License
1 stars 2 forks source link

Fixes include folder installation. #220

Closed francocipollone closed 2 years ago

francocipollone commented 2 years ago

Part of https://github.com/maliput/maliput_infrastructure/issues/275

action-ros-ci-override: https://gist.githubusercontent.com/francocipollone/18dfba70fefe81314bc8a68138732f53/raw/f87e9a6f8e2a6241fbe79db063158bfca5972b41/prs.repos

francocipollone commented 2 years ago

LGTM. This won't pass CI until maliput/maliput_drake#23 or maliput/maliput#508 (review) are merged, released, and rebuilt.

francocipollone commented 2 years ago

maliput and maliput_drake have been built already, It should be ok now to be re-triggered. I tried to retrigger it but I am not sure if I am a bit rusty with jenkins or if I don't have the bits to retrigger it. :D @tfoote

tfoote commented 2 years ago

You can request a retry from Jenkins by commenting here like this.

@ros-pull-request-builder retest this please

tfoote commented 2 years ago

The build passed, but has linter errors which are why it shows error now.

francocipollone commented 2 years ago

The build passed, but has linter errors which are why it shows error now.

image

Is it a requirement to fix all the warnings? What's the best approach when using marked-as-deprecated api?

CC: @agalbachicar

francocipollone commented 2 years ago

Issues were solved via 221 and 222. Build farm should be happy now.

When merging we should: Rebase and Merge

francocipollone commented 2 years ago

@tfoote Issues are resolved! https://build.ros2.org/job/Fpr__maliput_malidrive__ubuntu_focal_amd64/8/