maliput / maliput_malidrive

Open-source ready OpenDrive backend for Maliput

BSD 3-Clause "New" or "Revised" License

0 stars 2 forks source link

Enables regression testing in bazel. #246

Closed francocipollone closed 8 months ago

francocipollone commented 11 months ago

🎉 New feature

closes https://github.com/maliput/maliput_malidrive/issues/247

Summary

Now that maliput::test_utilities is gtest-free: https://github.com/maliput/maliput/issues/591 we can enable bazel testing in maliput_malidrive
https://github.com/maliput/maliput/pull/608 is necessary to correctly build tests.

Checklist

[x] Signed all commits for DCO
[ ] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if it affects the public API)

francocipollone commented 11 months ago

@stonier One quick question as you have experience here. PR in maliput has been merged, now the test_utilities library is part of maliput. However, here the bazel job isn't finding that library. Do we have to manually push to BCR maliput like a "new release"?

francocipollone commented 11 months ago

@stonier One quick question as you have experience here. PR in maliput has been merged, now the test_utilities library is part of maliput. However, here the bazel job isn't finding that library. Do we have to manually push to BCR maliput like a "new release"?

Friendly ping here @stonier

francocipollone commented 11 months ago

I retriggered CI and now it is failing due to another issue not related to this PR:

ERROR: Error computing the main repository mapping: in module dependency chain <root> -> bazel_tools@_ -> rules_cc@0.0.9: module not found in registries: rules_cc@0.0.9

francocipollone commented 11 months ago

I retriggered CI and now it is failing due to another issue not related to this PR:
ERROR: Error computing the main repository mapping: in module dependency chain <root> -> bazel_tools@_ -> rules_cc@0.0.9: module not found in registries: rules_cc@0.0.9

This is fixed

francocipollone commented 11 months ago

@stonier One quick question as you have experience here. PR in maliput has been merged, now the test_utilities library is part of maliput. However, here the bazel job isn't finding that library. Do we have to manually push to BCR maliput like a "new release"?

Going back to this. I assume we have to create a maliput release that ships test_utilities library. Correct? @stonier

francocipollone commented 10 months ago

Pendings:

[x] private_test_headers targets aren't really private as I want to use it in the test targets. (as commented here https://github.com/maliput/maliput_malidrive/pull/246#discussion_r1409508371)
[ ] Plugin tests weren't enabled as the test suite for testing the plugin architecture isn't well set up for bazel.
- This should be probably tackled in a follow-up PR so I will create an issue for this https://github.com/maliput/maliput_malidrive/issues/268

stonier commented 8 months ago

If bazel test //... now does something, you could/should enable them in https://github.com/maliput/maliput_malidrive/blob/main/.bcr/presubmit.yml

Otherwise, LGTM.

francocipollone commented 8 months ago

I will proceed and merge it

francocipollone commented 8 months ago

If bazel test //... now does something, you could/should enable them in https://github.com/maliput/maliput_malidrive/blob/main/.bcr/presubmit.yml

Otherwise, LGTM.

Done!