search

maliput / maliput_malidrive

Open-source ready OpenDrive backend for Maliput
BSD 3-Clause "New" or "Revised" License
1 stars 2 forks source link

Improve xodr_validate error message when junction does not define any connections #54

Closed liangfok closed 3 years ago

liangfok commented 3 years ago

See this Slack thread.

Example error message:

./install/maliput_malidrive/bin/maliput_malidrive/applications/xodr_validate --xodr_file ~/path/to/invalid.xodr
Failure at /home/liang/dev/maliput_ws/src/maliput_malidrive/maliput_malidrive/src/maliput_malidrive/xodr/parser.cc:873 in As<malidrive::xodr::Junction>(): condition 'connection_element != nullptr' failed.
The map could not be loaded.

Ideally, the error message should list which junctions do not have any connections.

According to the OpenDrive specification(Rev. 1.5) the junction must define at least one connection.

liangfok commented 3 years ago

Closing this in favor of #55, which tracks modifying the builder to support junctions without connections.