Install window bug - Githubissues

malisipi / VInstall

A cross-platform installer creator

Apache License 2.0

37 stars 3 forks source link

Install window bug #5

Open KingBes opened 3 months ago

KingBes commented 3 months ago

There is a major bug, other files in the same directory are deleted when the installation window is closed!

malisipi commented 3 months ago

Can you provide the installer code that you used. The behavior is only designed for uninstaller.

KingBes commented 3 months ago

module main

import malisipi.vinstall

#flag windows -mwindows

fn main() {
    vinstall.run(
        app_developer: 'KingBes'
        app_name: 'PHP麻蛋编辑器'
        license_txt: $embed_file('license.txt')
        app_zip: $embed_file('PHP麻蛋编辑器.zip')
        executable_path: 'run.exe'
        desktop_shortcut: true
        uninstaller:$embed_file('uninstaller.exe')
        default_language:'Chinese'
    )!
}

malisipi commented 3 months ago

I tested the code and I recognize some problems.

Files is deleted only if runned uninstaller.exe. Or files is deleted if the files is located on installation location. It's actually not a bug, it's undocumented behavior. If the bug is caused from them, please say it. If the issue caused from that, I may add a option to disable the behavior.
Shortcuts names will not rendered as correctly. I have not much thing to fix this, Microsoft's API is accepts only ASCII. Maybe I can search another API that supports UTF-8. But you can choose a English name alternative for application name until fixed.

It's a virtual machine record that removed a lot of components including chinese/japanese/emoji fonts removed. So dialogs is not readable. It's not related with Installer.

Ekran kaydı - 2024-06-07 17-27-40.webm

malisipi commented 3 months ago

By this commit 5c717a364e937670197e54cf7ba13f550617ce0c, you will be able to protect files/folder that located in installation location. You just need to pass -d dont_delete_install_location_files flag. However using uninstaller is not recommend for this situation. Uninstaller will wipe all files/folder that placed in installation location.

malisipi commented 3 months ago

You can use the command for your situation. v installer.v -d extended_language_support -d dont_delete_install_location_files -o installer.exe

KingBes commented 3 months ago

https://github.com/malisipi/VInstall/assets/48203677/95f043af-7db8-403e-ac70-72413c4ff8bc