Adding Probabilistic Graphs

[maljovec]

• Switching to a pure python codebase, possibly sacrificing performance for maintainability. The goal is to move quickly here to keep up with nglpy_cuda. More performance-centric users should consider using that library instead. Possibly there are ways to optimize this on Python that we can consider.

[pep8speaks]

Hello @maljovec! Thanks for updating the PR.

• In the file nglpy/Graph.py, following are the PEP8 issues :

  Line 285:80: E501 line too long (100 > 79 characters)

• There are no PEP8 issues in the file nglpy/ProbabilisticGraph.py !

• There are no PEP8 issues in the file nglpy/SKLSearchIndex.py !

• There are no PEP8 issues in the file nglpy/SearchIndex.py !

• There are no PEP8 issues in the file nglpy/__init__.py !

• There are no PEP8 issues in the file nglpy/tests/test_Graph.py !

• There are no PEP8 issues in the file setup.py !

Comment last updated on October 04, 2018 at 06:47 Hours UTC

[coveralls]

Pull Request Test Coverage Report for Build 33

• 150 of 297 (50.51%) changed or added relevant lines in 5 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-45.7%) to 46.803%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
nglpy/SKLSearchIndex.py	15	17	88.24%
nglpy/SearchIndex.py	6	9	66.67%
nglpy/ProbabilisticGraph.py	10	35	28.57%
nglpy/Graph.py	112	229	48.91%
<!--	Total:	150	297	50.51%	-->

Totals
Change from base Build 28:	-45.7%
Covered Lines:	150
Relevant Lines:	297

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 33

• 150 of 297 (50.51%) changed or added relevant lines in 5 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-45.7%) to 46.803%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
nglpy/SKLSearchIndex.py	15	17	88.24%
nglpy/SearchIndex.py	6	9	66.67%
nglpy/ProbabilisticGraph.py	10	35	28.57%
nglpy/Graph.py	112	229	48.91%
<!--	Total:	150	297	50.51%	-->

Totals
Change from base Build 28:	-45.7%
Covered Lines:	150
Relevant Lines:	297

---

💛 - Coveralls

[dmaljovec]

The difference between main and this branch executing on a one million point set is ~20s versus 6.5 minutes. Perhaps we want to keep the C++ implementation for now and consider how we can improve this computation.