Critical Bug fix: Reversing edges on negated Morse complex built for Morse-Smale construction

maljovec / topopy

A library for computing topological data structures stemming from Morse Theory. Given a set of arbitrarily arranged points in any dimension, this library is able to construct approximate topological structures using a neighborhood graph to simulate manifold structures.

BSD 3-Clause "New" or "Revised" License

20 stars 6 forks source link

Critical Bug fix: Reversing edges on negated Morse complex built for Morse-Smale construction #26

Closed maljovec closed 6 years ago

pep8speaks commented 6 years ago

Hello @maljovec! Thanks for updating the PR.

There are no PEP8 issues in the file topopy/MorseComplex.py !
There are no PEP8 issues in the file topopy/tests/test_msc.py !

Comment last updated on September 12, 2018 at 06:23 Hours UTC

maljovec commented 6 years ago

Another test case should be added that does not rely on a regular grid structure since the existing tests pass for this reason. That is, the reversed edge structure is exactly the same as the points in the forward direction.

coveralls commented 6 years ago

Coverage increased (+0.02%) to 98.185% when pulling 52e2b00cc6aa4770babb700d4023cd22d1c94bb9 on devel into bf473c725a51abf9561d2cb506540f7457d20c5b on master.