malkazwini / phurl

Phurl
0 stars 0 forks source link

Source Optimization #128

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Edit ./index.php

What version of the product are you using?
2.4.2

Please provide any additional information below.

Now 71~77 lines of ./index.php file is here

            $old_alias = $url_data[2];

            if (strlen($alias) > 0) {
                if ($old_alias != $alias) {
                    $create = true;
                }
            }

At this context, alias_exists($alias) is false. So ($old_alias != $alias) is 
always true.
Then, above scripts can be replaced with the scripts the following.

            if (strlen($alias) > 0) {
                $create = true;
            }

Sincerely,
Kenneth Roy
noersoft@gmail.com

Original issue reported on code.google.com by noers...@gmail.com on 8 Sep 2011 at 4:03

GoogleCodeExporter commented 8 years ago
Thanks, appreciated.

Original comment by he...@phurlproject.org on 15 Dec 2011 at 12:59

GoogleCodeExporter commented 8 years ago

Original comment by he...@phurlproject.org on 29 May 2012 at 11:30