mallardduck / php-whois-client

A very basic Whois client for PHP. The library limits function to be a low-level client that handles only request and raw output.

GNU General Public License v3.0

16 stars 3 forks source link

Test improvement #16

Closed peter279k closed 4 years ago

peter279k commented 4 years ago

Changed log

Using the assertIsString to expected type is string.
Using the assertIsObject to expected type is object.
Using the assertNotEmpty to expected type is set and not empty.
According to the PHPUnit fixtures reference, the setUp method is protected function setUp(): void.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 135

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 134:	0.0%
Covered Lines:	57
Relevant Lines:	57

💛 - Coveralls

codecov[bot] commented 4 years ago

Codecov Report

Merging #16 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             master    #16   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity       25     25           
=======================================
  Files             6      6           
  Lines            67     67           
=======================================
  Hits             67     67

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4d5c804...faf13cb. Read the comment docs.

mallardduck commented 4 years ago

Hey thanks for this! I'll take a look over the PR later tonight.