malllabiisc / EmbedKGQA

ACL 2020: Improving Multi-hop Question Answering over Knowledge Graphs using Knowledge Base Embeddings
Apache License 2.0
412 stars 95 forks source link

webqsp dataset: full 0.439317 accuracy, half 0.346397 #115

Closed lihuiliullh closed 2 years ago

lihuiliullh commented 2 years ago

May I know how do you run your model in webqsp dataset? I use the following command to run the model on webqsp half

python3 main.py --mode train --relation_dim 200 --do_batch_norm 1 \ --gpu 2 --freeze 1 --batch_size 16 --validate_every 10 --hops webqsp_half --lr 0.00002 --entdrop 0.0 --reldrop 0.0 --scoredrop 0.0 \ --decay 1.0 --model ComplEx --patience 20 --ls 0.05 --l3_reg 0.001 --nb_epochs 200 --outfile half_fbwq

and the following command to run the model on webqsp full python3 main.py --mode train --relation_dim 128--do_batch_norm 1 \ --gpu 2 --freeze 1 --batch_size 16 --validate_every 10 --hops webqsp_half --lr 0.00002 --entdrop 0.0 --reldrop 0.0 --scoredrop 0.0 \ --decay 1.0 --model ComplEx --patience 20 --ls 0.05 --l3_reg 0.001 --nb_epochs 200 --outfile half_fbwq

But the accuracies are full 0.439317 accuracy, half 0.346397.

apoorvumang commented 2 years ago

are you using the pre-trained complex embeddings? @lihuiliullh

lihuiliullh commented 2 years ago

yes, I think so. Because I downloaded the pretrained_models.zip, and used the above command line. @apoorvumang

lihuiliullh commented 2 years ago

wait for a while, let me get back to you later. Because I found that the "nb_epochs" I used is 20 instead of 200.

apoorvumang commented 2 years ago

did you get a chance to run with 200 epochs? @lihuiliullh

lihuiliullh commented 2 years ago

yes, I ran 200 epochs. The accuracy for full is 0.56, for half is 0.47. @apoorvumang How do you get the accuracy in the paper?

apoorvumang commented 2 years ago

do these numbers include relation matching, or just the output of training script? @lihuiliullh

lihuiliullh commented 2 years ago

How to do relation matching? I just follow the instruction on the github, and ran the command. @apoorvumang

apoorvumang commented 2 years ago

please see this https://github.com/malllabiisc/EmbedKGQA/blob/master/KGQA/RoBERTa/README.md

lihuiliullh commented 2 years ago

Do you have half version dataset like webqsp_scores_full_kg_fixed.pkl? If I want to run the half datset, what should I do? @apoorvumang

lihuiliullh commented 2 years ago

Also, may I know how do you get the candidates in webqsp_scores_full_kg_fixed.pkl? Are they the top-200 prediction of the very basic model without relation matching and 2-hop filter?

apoorvumang commented 2 years ago
  1. I do not yet have saved scores for half-kg model output. Will update you once I get it. You can however get scores from your own model through the instructions outlined in the above mentioned readme (you will have to uncomment a line in code to save file)

  2. The given scores file contain top-200 prediction without relation matching, without 2-hop filter

apoorvumang commented 2 years ago

closing since remaining points have been raised in another issue