search

mallorybowes / chrome-mal-ids

Effort to list and aggregate known malicious Google Chrome Extension IDs
49 stars 14 forks source link

Add a progress bar? #6

Closed mallorybowes closed 4 years ago

mallorybowes commented 4 years ago

Not sure if this is entirely needed since the core bash script is just comparing two text files. But I'm thinking there may be ppl with more extensions than I have and if they're in the hundreds (why?), then the comparison operation might take a bit longer and the script will look like it's hung. So maybe this is needed going forward when there may be 1000's of malicious IDs to scan on someone's machine that has 100's of extensions...

mallorybowes commented 4 years ago

I was thinking I could just echo out the search contents ("Searching for $extension...", then on completion of the individual search echo out "$extension not found.") as a rudimentary progress "bar." Idk, I always like more info than less so I'd be ok w/this approach but it would fill the terminal with useless info... Ideally, some sort of spinning progress thingy would be ideal ($extension |/).

mallorybowes commented 4 years ago

Added a command line arg "-v" to turn on bash shell debug. The script runs so fast that an actual progress bar isn't needed. Plus, you can now see what the script is doing in the background.