malloydata / malloy

Malloy is an experimental language for describing data relationships and transformations.
http://www.malloydata.dev
MIT License
1.99k stars 76 forks source link

Local testing of imdb for outside contributors #526

Closed greg-finley closed 2 years ago

greg-finley commented 2 years ago

It would be great if outside contributors can get all tests to pass locally. Because the imdb dataset is not public (as discussed here), the packages/malloy-db-test/src/production_models.spec.ts tests fail for it.

Some ideas:

  1. Allow people to skip that model in the local tests based off their dotenv settings.
  2. Allow people to point at their copy of the data, though they need to run the script and storing this data puts you over the Google Cloud free-tier limits.

If we like No. 1, I can PR it.

greg-finley commented 2 years ago

imdb stuff is gone after https://github.com/looker-open-source/malloy/pull/558