search

mallrat208 / UBC-Ore-Registrar

Minecraft Mod and Add-on for Underground Biomes Construct.
MIT License
4 stars 7 forks source link

Galacticraft, Jaffas and More, Tainted Magic, Clockwork Phase, Electrical Age and Fossils and Archeology Revival support #8

Closed Mysteryem closed 9 years ago

Mysteryem commented 9 years ago

I've added support for Galacticraft, Jaffas and More, Tainted Magic, Clockwork Phase, Electrical Age and Fossils and Archeology Revival as I'm building a private modpack that contains these mods (amongst others). I see no reason not to share what I've done.

I realise now, looking at the diff on github that I've used spaces instead of tabs throughout my code so that may turn you off from straight up accepting the pull request, but feel free to pick what you want from what I've done.

One other thing I will note about this PR is that the Fossil overlay (fFossil_overlay.png) doesn't look anything like the fossil blocks from the Fossils and Arch[...] mod as I couldn't create an overlay from it that looked half decent due to only being able to use zero or full transparency in the overlay file.

It's also worth noting that jdpadrnos' fork has support for Artifice and Evilcraft as well as Galacticraft. My modpack has neither of those other mods, so I've not included them as I would not be able to test them.

mallrat208 commented 9 years ago

Looks pretty nice actually. The only thing I'd have any reservations about are some of the textures. For the most part I've been trying to reuse textures.. for example all Copper Ore has the same Overlay. Aluminum and Bauxite are exceptions since while functionally the same for most mods, there are some that don't process them the same way.

Mysteryem commented 9 years ago

Ah, I was going on the basis that should a player have only one type of copper ore in a modpack (or at least only one type spawning), they would want the UBC ore to look like the one type of ore that they have, as opposed to a different one. I think that in most mod packs, their config files are set up such that only one mod's version of an ore is generated.

I've just added Matter Overdrive and Minechem to the modpack, so I'll be adding support for those too (and may add more mods in the future), want me to change what I've done so that they're all using the same copper/tin/etc. textures? I will keep Fossils and Arch... amber from looking different as it's not in the ore dictionary and gives noticeably different drops to Thaumcraft's Amber Bearing Stone and BOP's Amber Ore. When it comes to Bauxite Ore, Immersive Engineering's version is in the ore dictionary as oreAluminum so it seems functionally equivalent to other ores in the dictionary under that name.

mallrat208 commented 9 years ago

It's not really a crucial change. Nor does it hurt things for the textures to be different.