search

malnvenshorn / OctoPrint-CostEstimation

OctoPrint plugin to display the estimated print cost for the loaded model
GNU Affero General Public License v3.0
23 stars 19 forks source link

adds python 3.7 compatibility #28

Open benjamin-salchow opened 4 years ago

benjamin-salchow commented 4 years ago

I upgraded to Python 3.7 and I could not run your plug-in.

I got the following error: "Plugin Cost Estimation (2.1.3) is not compatible to Python 3.7.3 (compatibility string: >=2.7,<3)."

So I just added the __plugin_pythoncompat__ information and run this plugin. Now it works like a charm with Python 3.7.3 and I had no issue with my OctoPrint setup.

fractalsauce commented 4 years ago

Hi, I just upgraded my octoprint installation to python 3 and would like to install this plugin with python 3 support. Could you tell me how I would do this? I'm sorry I'm a noob to all this, but I'm guessing I would need to merge your changed file with the rest of the files in the plugin before installing it. But I have no idea how I would go about doing that.

I know how to do a few things in the terminal, but I don't know how I would manually download individual files, compile the plugin, then install it.

I understand if it's too much to explain, but if you could point me in the right direction, it'd be greatly appreciated. Thanks!

codingcatgirl commented 4 years ago

@fractalsauce basically, @benjamin-salchow forked this plugin to make the changes necessary for it to run under python3. you can find that fork here. https://github.com/benjamin-salchow/OctoPrint-CostEstimation using the "unstall from url" feature in octoprint, you should be able to install the fork :)

fractalsauce commented 4 years ago

@codingcatgirl Oh awesome thanks! I thought that might be the case but I couldn't find a link to the fork anywhere. How would I go about finding said link in the future?

benjamin-salchow commented 4 years ago

The easiest way would be to merge my fix into the master branch of this repository, then the automatic update of octoprint would work. But I guess this plug-in is not actively maintained any more. My pull request is from march and still not accepted or included.

Yes, as a workaround you can use my fork with the Python 3 fix.

@malnvenshorn could you please check and merge it. Thank you very much :-).

fractalsauce commented 4 years ago

@benjamin-salchow Hey I finally got it working thanks! Just wanted to point out that on your forked page under setup and the bottom, you still have the original link to @malnvenshorn 's version. Took me a sec to figure out why it was still saying it didn't support Python 3 and still wasn't working when I tried to install it in the Plugin manager. Might wanna update that. Anyways thank you all again, problem solved! :D