malnvenshorn / OctoPrint-FilamentManager

OctoPrint plugin to manage your filament inventory
GNU Affero General Public License v3.0
131 stars 59 forks source link

Unable to select spool; have to close and reopen 2nd time to select. #195

Open Silventar opened 4 years ago

Silventar commented 4 years ago

Describe the bug When I start a print from the Octoprint file manager, it creates a popup to allow me to select a spool. However, the spools drop down is not shown. About one second later, in the background, Octoprint shows a "frame size calculated" message in the top right of the screen that lasts for a couple seconds. If I close the Filament Manager popup click the print again, the new popup shows the drop-down.

This seems to only happen if I send the gcode from my slicer and move to Octoprint immediately to start the print. If I wait a minute or two after sending the gcode to start the print, the issue does not happen.

Steps to reproduce

  1. Go to the Octoprint File Manager in the sidebar, press the print icon for the file to print.

Expected behavior The Frame Size Calculated message should display, then the Filament Manager popup should display to select the spool of choice.

Did the same happen when all other 3rd party plugins are disabled? Yes.

Log file octoprint.log

Additional context Raspberry Pi 4B, 4mb RAM OctoPrint: 1.3.12 Filament Manager: 0.5.3

NameOfTheDragon commented 4 years ago

I'm also seeing this. I like being prompted to confirm the spool but usually the first time all the selection list and buttons are disabled so you have to cancel and hit Print again, then it will usually work.

hamster65 commented 4 years ago

same happens to me. I thought it might have something to do with the option to warn if the remaining filament is not enough for the print, so I disabled this options. Did not help. I absolutely need the prompt for the spool selection to remember to set the right one....

ATSiem commented 4 years ago

Selected Spool - Greyed Out Printing Button

This is still an issue on my new install of OctoPi 0.17.0 with OctoPrint 1.4.0.

I am unable to print anything unless the Filament Manager is disabled. As @NameOfTheDragon described, I cannot print, and even clicking Cancel does not work - as the Print button is greyed out for my model until I restart OctoPrint without the Filament Manager plugin.

I tested this on used cache on Safari, and a fresh cache of Chrome - both with the same issues.

ATSiem commented 4 years ago

@malnvenshorn Could this bug (inconsistent ability to 1. select spool and 2. click active 'print button' - that is not greyed out) be something to do with modal confirmation - controlled by the framework?

Here is the modal to confirm spools: https://github.com/malnvenshorn/OctoPrint-FilamentManager/blob/master/octoprint_filamentmanager/templates/spool_confirmation.jinja2

For example...

Is it that the event is not consistently sent to allow the 'print' button to be activated?

I see the print button is waiting on this to be enabled as part of the data-bind:

event: { change: function() { $root.viewModels.confirmation.checkSelection();

posicat commented 4 years ago

I ran into this on my machine, looks like it was just a case of the database not being online when the Octoprint server got started. I put postgresql in as a dependency on my octoprint service and it worked fine after that.

ATSiem commented 4 years ago

When you saw the error, did you have no spool toggle, or a toggle and you were unable to select ‘print’? On Apr 12, 2020, 9:46 PM -0400, Mark notifications@github.com, wrote:

I ran into this on my machine, looks like it was just a case of the database not being online when the Octoprint server got started. I put postgresql in as a dependency on my octoprint service and it worked fine after that. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

FixxCZ commented 4 years ago

Having the same issue on OctoPi 0.17.0 with OctoPrint 1.4.0. and Filament Manager 0.1.4. I have to click cancel go to dropdown and select none in the Tool 0. Then it allow me to choose it.

FixxCZ commented 4 years ago

Resolved it in Brave browser by disabling the shield. No problem since then.