search

malonzo47 / pynita_GUI

pynita_GUI is python GUI based implementation of Noise Insensitive Trajectory Algorithm (NITA)
4 stars 3 forks source link

recovery years not specified (metric image creation) #66

Closed malonzo47 closed 4 years ago

malonzo47 commented 4 years ago

The recovery image appears to have a hardcoded number of years. The user should be able to specify this number at the time of metric image generation. (Similar functionality to specification of custom value change)

malonzo47 commented 4 years ago

The user should be able to specify a number of years over which to judge recovery of vegetation index value.

This year value currently is hardcoded as "1" in pynita_gui_main in line 1071: nita.MI_recovery(1, option='diff', plot=self.plot12.isChecked(), save=self.save12.isChecked(), fn='recovery.tif', title = title, label=label)

This value should, instead be updated by user from Step 4, #12 Label in GUI (in blue text like "Start Date"): "Years:"

The same change should be made for Step 4, #13. (See pynita_gui_main line 1076). Label in GUI (in blue text like "Start Date"): "Years:"

FreelanceDev217 commented 4 years ago

Fixed. Please check the master branch running from the source.

malonzo47 commented 4 years ago

Seems to work. Two small changes: 1) make text boxes for user data entry no larger than they need to be to fit, for example, yyyyddd; 2) allow for multiple Recovery plots to be open at the same time. For instance, I should be able to run a 2 year recovery to create a plot labeled "Recovery 2" and then a 1 year recovery popping up "Recovery 1". (Multiple window functionality should be like "Value Change Custom" which currently allows for this and names them specifically)

FreelanceDev217 commented 4 years ago

Fixed. Please check the latest source at the master branch.

malonzo47 commented 4 years ago

Number 1 is not fixed. The boxes are still the same size: image

malonzo47 commented 4 years ago

Number 2 looks good!

FreelanceDev217 commented 4 years ago

Fixed.

malonzo47 commented 4 years ago

This is still not fixed for all three boxes. We're talking about Recovery here and neither of those have been updated: image

FreelanceDev217 commented 4 years ago

Well, because we can have several year values in Recovery and Recover CMP, I think it's hard to set the limit of the width of these two textboxes. Please let me know your thought. How many characters shall we limit the inputs?

malonzo47 commented 4 years ago

Never needs more than 3 characters. Thanks!

On Fri, May 1, 2020 at 5:19 PM FreelanceDev notifications@github.com wrote:

Well, because we can have several year values in Recovery and Recover CMP, I think it's hard to set the limit of the width of these two textboxes. Please let me know your thought. How many characters shall we limit the inputs?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/malonzo47/pynita_GUI/issues/66#issuecomment-622572696, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADUHL7EDR5UHRCF75MBMJVDRPM4E5ANCNFSM4K4RX6YQ .

FreelanceDev217 commented 4 years ago

Fixed.

malonzo47 commented 4 years ago

Looks good.