search

malparty / keywords

Codding challenge
0 stars 0 forks source link

Missing dependency for Bootstrap #28

Closed olivierobert closed 3 years ago

olivierobert commented 3 years ago

Environment

Steps to Reproduce

  1. Boot the application with dev.sh.
  2. Inspect the terminal output.

Expected

All dependencies should be defined in /keywords/KeywordsApp/ClientApp/package.json to ensure reproducibility of the development and production environments.

Actual

popper.js is missing from the definition of the dependencies: image

There are also some missing attribute in package.json which should be referenced.

malparty commented 3 years ago

I can recall what happened here: I forgot the --save tag when uninstalling Bootstrap/Jquery/... from the project. Indeed these dependencies are not part of the ClientApp project. I'll fix this as well as the other UI issues first. Thanks