search

malsubrata / woo-wallet

WooCommerce Wallet
GNU General Public License v3.0
78 stars 37 forks source link

Fix price on cart whn tax is included #80

Closed pedro-sigma closed 6 months ago

pedro-sigma commented 1 year ago

Hi !

We had a problem when tax is included. The price displayed on product list was different than the price displayed on cart. I think that i fixed it, you should check it and add it to next update.

pedro-sigma commented 1 year ago

Hey, I made some improvements. I added a filter before display the cashback order and an action after cancell an order. And also I think I fixed a bug when tax is included.

I think you may add this code to the plugin if you want !

Nice to meet you Pedro.

malsubrata commented 1 year ago

@pedro-sigma Thank you for expressing your interest in contributing. It appears that the code changes in commit https://github.com/malsubrata/woo-wallet/pull/80/commits/cbdf881e415c545efaf2e128a73013b39c84fb67 are not accurate. From my understanding, you intend to filter the HTML content, is that correct?

pedro-sigma commented 1 year ago

Oh sorry for my english. I'm tring to explaint a little better:

My first commit, "Fix price on cart whn tax is included" is because, when tax are included in the price, the cashback you give to does not include the tax, ever when they are included. So I think when tax are included, the cashback may include the tax too.

The second commit is just filter html, that's right.

and the thirth commit is to add an action after cancel a order. That because then an order is cancelled and the cashback is refunded I may want to do something, like send a notification to the user to tell them a refounded has happend.

if you need some information or you may want to change the modification, just tell me.