malsup / blockui

jQuery BlockUI Plugin
http://jquery.malsup.com/block/
1.69k stars 506 forks source link

add composer component package #107

Closed glensc closed 9 years ago

glensc commented 9 years ago

adds support for component and component installer for composer

tested with composer custom repo definition in composer.json:

    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/glensc/blockui"
        }   
    ]
    "require": {
        "components/jquery-blockui": "*@dev",

after PR merge, probably should:

  1. create new git tag (f.e 2.66) in blockui and push it to github (don't forget to update versions in source)
  2. register package on packagist.org
DiegoYungh commented 9 years ago

I created a fork with all PR I saw here https://github.com/DiegoYungh/blockui/commits/master

In the near future I will probably create a block feature on top of blockui and open to pull requests

glensc commented 9 years ago

@DiegoYungh your fork is lousy. you should had used original commits from this repo keeping original authors!

DiegoYungh commented 9 years ago

@glensc can't seem to pull these request, I'd love to have merged then in a prettier way. but in any case the records are in the commits

glensc commented 9 years ago

https://help.github.com/articles/checking-out-pull-requests-locally/

glensc commented 9 years ago

https://gist.github.com/piscisaureus/3342247

DiegoYungh commented 9 years ago

Nice, I will recreate with the same name, everything merged

glensc commented 9 years ago

you can just git reset b38dd8f add your commits and git push -f to overwrite github push

DiegoYungh commented 9 years ago

hahaha that's fantasgit! The only one I can't merge is #47 , no way... really check in a few minutes I will have a updated fork

Appart from that, I plan on changing a little blockUI, keeping the core/cross-browser treatment on the overlay and stuff, but changing the API to be more flexible, update status messages in the way, plus AMD support and bla bla bla...

Thanks a lot :+1:

glensc commented 9 years ago

and why the fork? did @malsup say he doesn't maintain anymore? maybe he can add you collabrator instead?

DiegoYungh commented 9 years ago

I actually sent him a mail, and he was last summoned on github in oct.7 With this many Issues and Stuff I imagine he is working on another project, or in a company that does not allow him some spare time to come here.

malsup commented 9 years ago

Yeah, I've been crazy busy lately. But most of the outstanding PRs look like I can one-click merge them into master (except 47).

glensc commented 9 years ago

Would you mind pushing out new version tag once you're done. as that's what composer (and maybe others) use for versioning.

malsup commented 9 years ago

New tag pushed.

glensc commented 8 years ago

i don't see you created composer integration for this package

https://packagist.org/search/?q=malsup

i see only malsup/form there