search

malsup / blockui

jQuery BlockUI Plugin
http://jquery.malsup.com/block/
1.69k stars 506 forks source link

relative position not removed on unblock #22

Closed yauhen closed 11 years ago

yauhen commented 13 years ago

There is fragment of code in block logic: if ($.css(this,'position') == 'static') this.style.position = 'relative';

The problem is that after unblock it is not ralled back. So if inside div are absolute positioned element (like lightweight dialogs) they logic will be broken

carlos-soto commented 11 years ago

I can repro this issue... it's pretty annoying

carlos-soto commented 11 years ago

Closed? Is there a fix for it? Help please.

johnhoven commented 11 years ago

Yes, there's a commit (2.55) included if you check the thread in GitHub. Or just pull the latest version. Note min jquery version went from 1.3 to 1.7 in the header, but I don't see what in this commit would have required that.

On Fri, Jan 18, 2013 at 3:56 PM, carlos-soto notifications@github.comwrote:

Closed? Is there a fix for it? Help please.

— Reply to this email directly or view it on GitHubhttps://github.com/malsup/blockui/issues/22#issuecomment-12442806.

John Hoven hovenj@gmail.com

malsup commented 11 years ago

Last commit should fix this issue.

http://malsup.github.com/jquery.blockUI.js

malsup commented 11 years ago

re: 1.7 requirement, I don't want to deal with any issues for earlier jQuery versions. But you're right, nothing changed specifically to warrant that.

carlos-soto commented 11 years ago

Great news, thanks a lot!