search

malsup / cycle2

2nd gen cycling
899 stars 239 forks source link

Fix for jQuery 3.0 load() deprecation. Fixes #778 #779

Open jakeparis opened 8 years ago

jakeparis commented 8 years ago

jQuery 3.0 has deprecated the load function. In this case, we wanted to check for something on the load event anyway, so we switch to using .on('load')

dmethvin commented 8 years ago

LGTM ... in the meantime you should be able to use jQuery Migrate 3.0 to get the current version running again.

robinwilson16 commented 7 years ago

Thanks for your fix. I can confirm this resolves the issue with the latest version of jQuery. I notice that no changes seem to have been committed for over two years so am wondering if this project is still active?

ghost commented 7 years ago

I think the project is dead.

jakeparis commented 7 years ago

Yes, but it still works well.

ghost commented 7 years ago

@jakeparis yeap, we use it too. But, I think the author should give other persons write access to maintain the project if he can't.

robinwilson16 commented 7 years ago

It's a shame as Cycle2 is a really nice plugin

ghost commented 7 years ago

@malsup are you alive?

tmuka commented 6 years ago

thanks for this fix. after it cycle2 worked with my jquery v3.2.1.

FisherFast commented 6 years ago

Thank you so much for the fix. That fixed one of my slide shows, but I also use the carousel feature with Cycle2 and that has an additional jquery file. This feature doesn't seem to work with jquery 3.0.

Is there any way to tell what might need to be updated to get the carousel to work with Jquery 3.0?