search

malsup / cycle2

2nd gen cycling
898 stars 237 forks source link

Replace $.trim() with String.prototype.trim() #848

Open miclgael opened 4 years ago

miclgael commented 4 years ago

$.trim() is deprecated in jQuery 3.5.0

Upgrading jQuery is now a bit of a breaking change for cycle2 as far as I can see.

iam-sysop commented 4 years ago

I will work on my fork I maintain to incorporate this fix. Thank you for heads up - as it appears this master branch is unmaintained...

EileenWeb commented 4 years ago

Thank you, can you please let me know when updated. Does this also mean that the fix will apply automatically or do we need to get a developer to fix the jquery?

With appreciation,

Eileen.

On Thu, Sep 17, 2020 at 1:20 PM sysop notifications@github.com wrote:

I will work on my fork I maintain to incorporate this fix. Thank you for heads up - as it appears this master branch is unmaintained...

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/malsup/cycle2/issues/848#issuecomment-693784062, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH5CCCB7CK2XU5DNLR3ANJ3SGF56FANCNFSM4MOVKJXA .

iam-sysop commented 4 years ago

I have updated my branch with changes as noted. Fixes include updates to support jQuery 3.x+ in the installation.

https://github.com/thecarnie/cycle2/releases/tag/2.1.6b

Testing and verification IS REQUIRED before putting into production.

miclgael commented 4 years ago

Just wanted to say thanks @thecarnie ! I'll leave this issue open so others can see, and hopefully one day your changes will be able to be merged. hah