Prevent accidental opening link

maltaisn / another-notes-app

Another notes app for Android, like there have been tens of thousands before.

Apache License 2.0

344 stars 36 forks source link

Prevent accidental opening link #108

Closed anedroid closed 1 year ago

anedroid commented 1 year ago

The problem When editing a note, it's super easy to accidentally touch on the link and it opens. Most of the times however I touch there not because I want to open it, but in order to set cursor there, append comma or return and put another link. The actual behaviour makes poor UX.

The solution I propose not to open the link if the keyboard is shown, because it means I am editing.

Android version: 12
Android distribution: LineageOS
App version: 1.5.0 F-Droid

maltaisn commented 1 year ago

I agree it's annoying. I'll look into it eventually...

smaragdus commented 1 year ago

I suppose that a good workaround for this problem would be implementation of view mode/edit mode. In view mode links are clickable, in edit mode they are not.

Urbexed commented 1 year ago

I agree it's quite annoying

maltaisn commented 1 year ago

Here's what I changed:

Clicked at the start and at the end of a link won't do anything. This also fixes the case where we clicked in the end margin very far from a link and it still opened it.
Clicking on a link will open a confirmation dialog. If cancel is clicked, nothing will happen and text editing can be done at the clicked position.