search

malte0811 / FerriteCore

MIT License
332 stars 27 forks source link

Potential issue in SmallThreadingDetector #158

Open lab3 opened 5 months ago

lab3 commented 5 months ago

Worlds hanging and crashing on chunkgen in SmallThreadingDetector

This operation seems like it shouldn't really cause any side effects. Any idea what might be going on?

https://github.com/iron431/irons-spells-n-spellbooks/blob/1.20.1/src/main/java/io/redspace/ironsspellbooks/worldgen/RemoveWaterProcessor.java

CrashLog message (1).txt

malte0811 commented 5 months ago

Is this reproducible? The threading detector optimization is disabled by default because of issues like this, but I have no idea why my implementation should behave differently from the vanilla one (despite going through both implementations very carefully multiple times). If I had a reproducible test case that would make debugging much easier.

In any case it is very unlikely that this is caused by the code you linked.

lab3 commented 5 months ago

Ok. Thanks. I'll see if I can get something reproducible