malte0811 / FerriteCore

MIT License
334 stars 24 forks source link

incompatibility with lithium's latest neoforge version for 1.21.1 #174

Open VaporeonScripts opened 1 month ago

VaporeonScripts commented 1 month ago

https://mclo.gs/2MyYH4B

VaporeonScripts commented 1 month ago

https://github.com/CaffeineMC/lithium-fabric/issues/569#issuecomment-2417394847

malte0811 commented 1 month ago

See #173: This is fixed in the dev build from this GH action run: https://github.com/malte0811/FerriteCore/actions/runs/11371242578 (the previous run did not upload artifacts due to a build script bug). Given that Lithium on Neo is only available from GH action builds too, I do not consider it important enough to create a new release for it. 1.21.2 seems to be close to a release, the "fix" will be included in the FC build for that.

VaporeonScripts commented 1 month ago

Yeah but I won't use 1.21.2 for my modpack? It should be back ported tho :C

malte0811 commented 1 month ago

If they actually release Lithium on Neo on 21.1 I'll look into making a new release. But the only statement I got from them so far was along the lines of "we don't know yet, maybe we'll do backports". Also, you can easily apply the "fix" yourself in a pack since it's just an option in the Lithium config.

VaporeonScripts commented 1 month ago

bro they just did :sob:

VaporeonScripts commented 1 month ago

https://www.curseforge.com/minecraft/mc-mods/lithium/files/5817196

VaporeonScripts commented 1 month ago

Also, you can easily apply the "fix" yourself in a pack since it's just an option in the Lithium config.

uh, where? also i cant even launch minecraft, so how can i edit that, i think u mean from config folder?

VaporeonScripts commented 1 month ago

image no config for lithium lol

malte0811 commented 1 month ago

I was not aware that they had released one 4 days after telling me that they weren't sure yet whether they would. So I assumed that you were one of the people testing their GH builds. I will try to get a build out tomorrow after I get back from work. You can ask the lithium team about instructions for the config, but GH issues are not for "chat-style" one-message-per-5-seconds conversations.

malte0811 commented 1 month ago

I did not get around to it the last two days (quite busy at work), but I've put the build on CF/MR now. CF still needs to be approved, MR should already be visible.

VaporeonScripts commented 1 month ago

alright